[bitflux-cms] Re: [Bx-bugs] [Bug 899] doctypes

[Christian Stocker]

Hi

Thanks for that patch, but I have some questions.

First: can't you put bx_xmldocconfig into bx_plugins_xmldoc_config?

Looks like that class will only be needed by the xmldoc plugin, so
bx/plugins/xmldoc/config.php is the more appropriate place than bx/,
where only general stuff should go.

Second: I'm a bit reluctant to add the
"stylesheet" => $collection->getStylesheetNameByRequest($filename,$ext),

by default to the bxcms action. It's another lookup added, which most
plugins don't need. OTOH, it doesn't look very expensive for most
plugins, so why not just adding it. There's just the other problem, that
it basically has the same meaning as the xslt parameter from .configxml.
Or do you use it for something else? Shouldn't it just be either xslt or
stylesheet?

But looks good, do you have some examples somewhere to actually check it
out?

chregu


On 27.1.2006 11:44 Uhr, bugzilla-daemon at bitflux.ch wrote:
> http://bugzilla.bitflux.ch/show_bug.cgi?id=899
> 
> 
> 
> 
> 
> ------- Additional Comments From qmax at mediasoft.ru  2006-01-27 11:44 -------
> Created an attachment (id=24)
>  --> (http://bugzilla.bitflux.ch/attachment.cgi?id=24&action=view)
> implementation
> 
> This is new plugin and resource xmldoc to handle random xml documents in
> collection.
> Also there's class to handle configuration of doctypes.
> 
> 
> 
> ------- You are receiving this mail because: -------
> You are the assignee for the bug, or are watching the assignee.
> You are the QA contact for the bug, or are watching the QA contact.
> _______________________________________________
> Bx-bugs mailing list
> Bx-bugs at lists.bitflux.ch
> http://lists.bitflux.ch/cgi-bin/mailman/listinfo/bx-bugs

-- 
christian stocker | Bitflux GmbH | schoeneggstrasse 5 | ch-8004 zurich
phone +41 44 240 56 70 | mobile +41 76 561 88 60 | fax +41 1 240 56 71
http://www.bitflux.ch | christian.stocker at bitflux.ch |  GPG 0x5CE1DECB